feat: self-host KaTeX and Mermaid assets#93
Conversation
Summary of ChangesHello @xihale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request shifts the project's dependency management for KaTeX and Mermaid from external CDNs to local self-hosting. This change enhances control over asset delivery, potentially improving loading reliability and reducing external network dependencies for rendering mathematical equations and diagrams. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request's goal to self-host KaTeX and Mermaid assets is a great initiative for improving performance and reliability. The implementation correctly updates the asset paths in layouts/post.shtml and the related documentation. However, the PR is currently broken because the main JavaScript files for both KaTeX (katex.min.js) and Mermaid (mermaid.min.js) are referenced but missing from the repository. Additionally, a large number of KaTeX files that don't seem to be used have been added, which could unnecessarily increase the repository's size. I've left a few comments with suggestions to fix these issues.
1 participant
No description provided.